https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38450

Wainui Witika-Park <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |et.nz

--- Comment #13 from Wainui Witika-Park <[email protected]> ---
(In reply to Alex Buckley from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > (In reply to Alex Buckley from comment #10)
> > > Hi Jonathan,
> > > 
> > > We are testing this patchset for backport to 24.05.x
> > > 
> > > I would like to check I am testing it correctly please:
> > > [skip]
> > > 
> > > Am I testing this incorrectly?
> > 
> > I think I've followed the exact same steps. However I have a diff
> > 
> > +#. For the first occurrence,
> > +#. SCRIPT
> > +#:
> > koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/
> > catalogue_detail.inc:78
> > +#: koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc:75
> > +#, fuzzy, c-format
> > +msgid "Waiting at %s since %s."
> > +msgstr "Billing date: %s From %s To %s %s All since %s %s "
> >  
> > +#. SCRIPT
> > +#:
> > koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/
> > catalogue_detail.inc:78
> > +#, fuzzy
> > +msgid "Waiting at %s, %s since %s."
> > +msgstr "Billing date: %s From %s To %s %s All since %s %s "
> > 
> > 
> > +#. SCRIPT
> > +#: koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc:1
> > +#, fuzzy
> > +msgid "A patron from %s"
> > +msgstr "User library"
> > 
> > Which are the expected changes.
> 
> 
> Thank you for testing Jonathan.
> 
> We will look into getting this backported next month - to 24.05.09, now we
> are so close to the March release.

I'm taking over from Alex this month for 24.05

This is what I am getting - 

Before applying patch:

$ gulp po:update --lang en-NZ
[08:33:17] Using gulpfile /kohadevbox/koha/gulpfile.js
[08:33:17] Starting 'po:update'...
[08:33:17] Starting 'po_update_marc_marc21'...
[08:33:17] Starting 'po_update_marc_unimarc'...
[08:33:17] Starting 'po_update_staff'...
[08:33:17] Starting 'po_update_opac'...
[08:33:17] Starting 'po_update_pref'...
[08:33:17] Starting 'po_update_messages'...
[08:33:17] Starting 'po_update_messages_js'...
[08:33:17] Starting 'po_update_installer'...
[08:33:17] Starting 'po_update_installer_marc21'...
[08:33:17] Starting 'po_update_installer_unimarc'...
[08:33:20] Finished 'po_update_installer_unimarc' after 3.03 s
[08:33:20] Finished 'po_update_installer' after 3.14 s
[08:33:20] Finished 'po_update_installer_marc21' after 3.22 s
[08:33:20] Finished 'po_update_pref' after 3.5 s
[08:33:20] Finished 'po_update_messages_js' after 3.65 s
[08:33:21] Finished 'po_update_marc_unimarc' after 4.41 s
[08:33:21] Finished 'po_update_opac' after 4.53 s
[08:33:22] Finished 'po_update_marc_marc21' after 5.29 s
[08:33:23] Finished 'po_update_messages' after 6.45 s
[08:33:27] Finished 'po_update_staff' after 11 s
[08:33:27] Finished 'po:update' after 11 s
$ cd misc/translator/po && git commit -a -m"wip"
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
[main 98e5f94049] wip
 14 files changed, 50077 insertions(+), 49564 deletions(-)
 delete mode 100644 debian/changelog
 delete mode 100644 debian/compat
 delete mode 100644 debian/control
 delete mode 100644 debian/koha-l10n.install
 delete mode 100755 debian/rules

After applying patch:

kohadev-koha@kohadevbox:koha((9845b28bc70...))$ gulp po:update --lang en-NZ
[08:37:32] Using gulpfile /kohadevbox/koha/gulpfile.js
[08:37:32] Starting 'po:update'...
[08:37:32] Starting 'po_update_marc_marc21'...
[08:37:32] Starting 'po_update_marc_unimarc'...
[08:37:32] Starting 'po_update_staff'...
[08:37:32] Starting 'po_update_opac'...
[08:37:32] Starting 'po_update_pref'...
[08:37:32] Starting 'po_update_messages'...
[08:37:32] Starting 'po_update_messages_js'...
[08:37:32] Starting 'po_update_installer'...
[08:37:32] Starting 'po_update_installer_marc21'...
[08:37:32] Starting 'po_update_installer_unimarc'...
[08:37:35] Finished 'po_update_installer_unimarc' after 2.92 s
[08:37:35] Finished 'po_update_installer' after 2.97 s
[08:37:35] Finished 'po_update_installer_marc21' after 3.1 s
[08:37:35] Finished 'po_update_pref' after 3.13 s
[08:37:36] Finished 'po_update_messages_js' after 3.48 s
[08:37:36] Finished 'po_update_marc_unimarc' after 4.1 s
[08:37:36] Finished 'po_update_opac' after 4.12 s
[08:37:37] Finished 'po_update_marc_marc21' after 4.84 s
[08:37:38] Finished 'po_update_messages' after 5.89 s
[08:37:40] Finished 'po_update_staff' after 7.89 s
[08:37:40] Finished 'po:update' after 7.89 s
kohadev-koha@kohadevbox:koha((9845b28bc70...))$ cd misc/translator/po && git
diff
diff --git a/en-NZ-staff-prog.po b/en-NZ-staff-prog.po
index afdf78a012..7d04445a4f 100644
--- a/en-NZ-staff-prog.po
+++ b/en-NZ-staff-prog.po
@@ -3,7 +3,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Koha 24.12.00.024\n"
 "Report-Msgid-Bugs-To: [email protected]\n"
-"POT-Creation-Date: 2025-04-15 08:33+0000\n"
+"POT-Creation-Date: 2025-04-15 08:37+0000\n"
 "PO-Revision-Date: 2024-10-08 03:00+0000\n"
 "Last-Translator: aleisha <[email protected]>\n"
 "Language-Team: Koha Translation Team\n"
@@ -10013,6 +10013,20 @@ msgstr "Unavailable (lost or missing)"
 msgid "Waiting at %s since %s"
 msgstr "Billing date: %s From %s To %s %s All since %s %s "

+#. For the first occurrence,
+#. SCRIPT
+#:
koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc:78
+#: koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc:75
+#, fuzzy, c-format
+msgid "Waiting at %s since %s."
+msgstr "Billing date: %s From %s To %s %s All since %s %s "
+
+#. SCRIPT
+#:
koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc:78
+#, fuzzy
+msgid "Waiting at %s, %s since %s."
+msgstr "Billing date: %s From %s To %s %s All since %s %s "
+
 #. For the first occurrence,
 #. SCRIPT
 #:
koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc:78
@@ -10743,13 +10757,6 @@ msgstr "Dewey: %s "
 msgid "Pending hold"
 msgstr "Pending reserves"

-#. %1$s:  Branches.GetName(hold.get_column('branchcode')) | html 
-#. %2$s:  hold.waitingdate | $KohaDates 
-#: koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc:75
-#, fuzzy, c-format
-msgid "Waiting at %s since %s."
-msgstr "Billing date: %s From %s To %s %s All since %s %s "
-
 #. %1$s:  hold.reservedate | $KohaDates 
 #. %2$s:  Branches.GetName(hold.get_column('branchcode')) | html 
 #: koha-tmpl/intranet-tmpl/prog/en/includes/item-status.inc:77
@@ -10767,6 +10774,12 @@ msgstr "Item level hold forced from OPAC %s %s "
 msgid "Restricted"
 msgstr "Restricted"

+#. SCRIPT
+#: koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc:1
+#, fuzzy
+msgid "A patron from %s"
+msgstr "User library"
+
 #: koha-tmpl/intranet-tmpl/prog/en/includes/keyboard_shortcuts.inc:3
 #, c-format
 msgid "Insert copyright symbol (©)"
@@ -71662,10 +71675,6 @@ msgstr ""
 #~ msgid "A new version of this site is available. Load it?"
 #~ msgstr "A new version of this site is available. Load it?"

-#, fuzzy
-#~ msgid "A patron from %s"
-#~ msgstr "User library"
-
 #, fuzzy
 #~ msgid "A patron from another library"
 #~ msgstr "User library"
@@ -76391,10 +76400,6 @@ msgstr ""
 #~ msgid "View staff catalog biblio enhancement plugins"
 #~ msgstr "View online payment plugins"

-#, fuzzy
-#~ msgid "Waiting at %s, %s since %s."
-#~ msgstr "Billing date: %s From %s To %s %s All since %s %s "
-
 #, fuzzy
 #~ msgid "Waiting recall at %s since %s"
 #~ msgstr "Billing date: %s From %s To %s %s All since %s %s "
kohadev-koha@kohadevbox:po(main)$ 

I think the above is expected behaviour.

Can I please have some guidance on next steps i.e. "Notice the changes, you
should see new translations added to the .po files. Ideally translate them,
install the templates and confirm that the new strings are translated on the
UI." <-- I'm not too sure what to do here

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to