https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24172
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #76 from Katrin Fischer <[email protected]> --- (In reply to Magnus Enger from comment #75) > (In reply to Katrin Fischer from comment #69) > > I am sorry, but this didn't cleanly auto_rebase - can you please rebase and > > send it back to my queue? I will get to it ASAP. > > Based on this comment from Katrin, I think the status here should be "Passed > QA"? > > > Please also give feedback to Jonathans comment, it sounds like a follow-up > > might be required > > Not sure if there was a followup for this yet? Unfortunately it wasn't :( Please in order to move this forward: 1) Help me understand and give feedback to Jonathan's comment. I admit I was dancing around this one a bit because I want to fully understand how it works and how it will affect existing subscriptions etc. and thought I'd need a longer quite time slot for this. 2) Fix QA test tool complaints. Please try to squash any tidy into the existing patches (no extra tidy patch): FAIL koha-tmpl/intranet-tmpl/prog/en/includes/localizer.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/includes/localizer.inc` OK koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt` FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt` FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt` OK koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/localizer.inc FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/includes/localizer.inc` FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt` Processing additional checks * Commit title does not contain 'follow-up' correctly spelt - 64a522df8ba -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
