http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #13 from Jonathan Druart <[email protected]> --- QA comment: I did not completely test this feature, but I have some comments: As Kyle said (in comment 3), I stop Apache but the browser redirects me to a standard error page after clicking on the bookmark. So I tested with a page which has been loaded when the service was running. I think I found a bug but it is weird that Chris did not raise that: When back to online, I upload transactions and delete all of them (or process them - the problem appears in both cases). Back to offline, check in 1 item and go online. I upload the transaction. I expect to have 1 pending offline action, but I get back all previous ones (Though I deleted them). What did I miss? Regarding at the code: 1/ there are minor qa issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 24) [...] forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 25) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 509) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 508) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 10) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 9) FAIL tt_valid lines 5, 5 2/ Maybe it could be great to pass perltidy on new scripts. 3/ download.pl could return data.finished = 1 if number of returned data < 5000 (avoid 1 ajax call) 4/ qq{} around sql queries should be replaced with q{} Possible improvements: 1/ it seems it is not possible to show local actions. 2/ add datatable on the tables. 3/ add a message on check in (currently the input becomes empty but the user is not informed). 4/ maybe a menu on the left with all links could help users (this would avoid to go back on the offline home page). I don't switch to Failed QA, like that another QAer could test deeper. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
