https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35288
Janusz Kaczmarek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #9 from Janusz Kaczmarek <[email protected]> --- There is a problem with this patch: the patch sets $form_mode to 'new' when one is importing record through Z39.50 ($op is not defined for Z39.50 import so the first condition $op eq '' is true, and $form_mode is set to 'new'). In this case $form_mode should be set to 'imported' but is not. To confirm: 1. set ApplyFrameworkDefaults to 'when cataloguing new records only' 2. in the default framework set any default value that you are not expecting to be present in a record imported from a Z39.50 source 3. import a record from z Z39.50 server 4. you will see the defined default value in the editor while you should not The problem of not identifying properly Z39.50 context for default values is present also in the current main branch, and could be easily corrected by changing line 96 of Koha/UI/Form/Builder/Biblio.pm from && ( ( $applydefaults =~ /new/ && !$self->{biblionumber} ) into && ( ( $applydefaults =~ /new/ && ! defined $self->{biblionumber} ) But with this patch (35288) the logic of setting the context changes completely. Having this patch there is no sense to make a separate patch for the spotted problem, but it would be more wise IMO to correct this patch to set the context for Z39.50 import properly. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
