https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38356
--- Comment #11 from Emmi Takkinen <[email protected]> --- (In reply to Katrin Fischer from comment #10) > (In reply to Emmi Takkinen from comment #9) > > (In reply to Jonathan Druart from comment #7) > > > Also > > > t/db_dependent/Circulation.t .. 68/76 # No tests run! > > > t/db_dependent/Circulation.t .. 70/76 > > > # Failed test 'No tests run for subtest "CanBookBeIssued + > > > needsconfirmation message"' > > > # at t/db_dependent/Circulation.t line 7094. > > > DBIC result _type isn't of the _type BiblioMetadata at > > > /kohadevbox/koha/Koha/Patron.pm line 854. > > > # Looks like your test exited with 11 just after 71. > > > > As far as I can tell t/db_dependent/Circulation.t tests are now failing > > randomly. They passed for me 3 times out of 5. But if I backtrack to the > > previous patch added to the main before these patches (bug 39775: Remove > > no-sort def), tests seem to pass every time. Also the line where they fail > > points to $biblio->is_serial which tries to check biblios metadata and is > > not related to the changes made here. Could it be possible that build_object > > sometimes fails to create metadata for the biblio object? If that's the case > > here it's weird that moving code around in the > > do_check_for_previous_checkout method has this kind of effect to building > > the test objects. > > Hi Emmi, thanks! I wonder if is_serial breaks because of Bug 39835 - Tidy > is_boolean / tinyint? My guess is that probably not. I changed the way test item is build in "CanBookBeIssued + needsconfirmation message" tests and now tests pass every time I run them. Will provide patch shortly so someone else can also confirm this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
