https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #194 from David Nind <[email protected]> --- I was going to sign off, but noticed these issues 8-(...: 1. Staff interface only - the patch "Allow for ending special characters in titles" does not seem to work as expected for the staff interface: 1.1 Search for a term that will show suggestions that include brackets, for example: greek 1.2 The suggestions do not show the end bracket. 1.3 If you select a suggestion without the ending bracket, you get "Error: Unable to understand your search query, please rephrase and try again.". 1.4 It seems to work okay in the OPAC. 2. OPAC only - when using the arrow keys to move between suggestions, background text on the page shows through: 2.1 From the OPAC home page, search for perl 2.2 Arrow down the suggestions. 2.3 Note that text behind shows through, for example the links under the global search box. 2.4 Go to the details page for any record. 2.5 Search again for perl 2.6 Arrow down the suggestions until you get to the block with "Place holds", "Print" and so on. 2.7 You may need to adjust the browser width to see this. 2.8 It seems to work okay in the staff interface. 3. Other languages - this is probably out of scope for this bug, but I noticed it anyway: 3.1 If you search for a record with the title in a different language, such as record 243, no suggestions are returned 3.2 For example, there are no suggestions when searching for ١٩٧٨ or السابعة 4. Suggestions for system preference names: 4.1 Instead of IntranetAutocompleteElasticSearch --> StaffInterfaceAutocompleteElasticsearch 4.2 Instead of OPACAutocompleteElasticSearch --> OPACAutocompleteElasticsearch 4.3 Rationale: 4.3.1 We spell Elasticsearch without a capital S everywhere else, as this is the name of the search engine, see Bug 39526 - Unify system preference variable names for Elasticsearch 4.3.2 We should use staff interface instead of intranet for new system preference names (see the terminology list) Consolidated test plan, or how I tested using KTD: 1. Start up KTD with Elasticsearch: ktd --es7 up 2. Apply the patches: git bz apply 27113 3. Update the database: updatedatabase 4. Update the CSS: yarn build 5. Restart everything: restart_all 6. Reset the Elasticsearch mappings: Koha administration > Catalog > Search engine configuration (Elasticsearch) > [scroll to the bottom of the page] > Reset mappings > Yes, reset mappings. 7. Reindex: koha-elasticsearch --rebuild -d -b -a kohadev 8. Before enabling the new system preferences for autocomplete, check searching in the OPAC and staff interface - there should be no noticeable change and things should work as expected. (I searched for perl, and got 11 results.) 9. Review the descriptions for the new system preferences and make sure they are clear and make sense (see the suggestions above for name changes): - IntranetAutocompleteElasticSearch - OPACAutocompleteElasticSearch 10. Enable the new system preferences: 11. Test the autocomplete/suggestion features for a standard search in the OPAC and staff interface: 11.1 Simple search, for example: perl - should show a list of suggestions, with the search term you entered highlighted - you can navigate the suggestions using the arrow keys (but not the tab key) - if it is an exact match and only one record (such as Perl template toolkit) it should go to that record - if there is more than one potential match, the one you select should appear first in the search results (such as Programming perl) 11.2 Search for records with quotation marks and brackets in them - change a title for a record so that it is now: MyTitle (1234) - search for My should show in suggestions - search for (1234 should show in suggestions - if you select the suggestion, it should return search results or show the record 11.3 Search for records with diacritics or accents in them, for example: Dàin - should show in the suggestions - should also show without the diacritics or accents, for example: dain 12. Repeat the searches in step 11 in the advanced search for the staff interface and OPAC. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
