http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494
Chris Cormack <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19158|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <[email protected]> --- Created attachment 19293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19293&action=edit Bug 10494: remove spurious warnings from the KohaBranchName plugin The KohaBranchName plugin now returns an empty string if given a NULL (undefined) library code or a library code that is not present in the database (e.g., the '__ANY__' placeholder that purchase suggestions can use). To test: [1] Create a purchase suggestion, setting the library to 'Any'. Create a second one setting the library to a specific one. [2] Go to the suggestions overview page in the staff interface. When you do so, the Apache logs should contain a warning that looks like this: [Wed Jun 19 07:13:06 2013] [error] [client 192.168.1.10] [Wed Jun 19 07:13:06 2013] suggestion.pl: Use of uninitialized value in concatenation (.) or string at /home/koha/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt line 487., referer: http://koha-staff.metaquarry/cgi-bin/koha/acqui/acqui-home.pl [3] Apply the patch. [4] Refresh the suggestions overview page. This time, there should be no new warning logged. [5] Verify that the library names for the two pending suggestions created in step 1 are displayed correctly. Signed-off-by: Galen Charlton <[email protected]> Signed-off-by: Chris Cormack <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
