https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28530
--- Comment #104 from Martin Renvoize (ashimema) <[email protected]> --- Comment on attachment 179944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179944 Bug 28530: Add Koha Object(s) for Float Limits Review of attachment 179944: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28530&attachment=179944) ----------------------------------------------------------------- ::: Koha/Library/FloatLimits.pm @@ +43,5 @@ > +sub lowest_ratio_library { > + my ( $self, $item, $branchcode ) = @_; > + > + my $field = C4::Context->preference('item-level_itypes') ? 'items.itype' > : 'biblioitems.itemtype'; > + my $query = qq{ Is it deliverate to continue using plain SQL here rather than constructing a DBIC query.. and should we perhaps be returning a Koha::Library object rather than a branchcode given this is a Koha:: object method? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
