https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364
--- Comment #22 from Marcel de Rooy <[email protected]> --- QA Comment Never give up! Thx for patching. + # Use first entry unless we find a preferred indicator1 = 3 + if ( $index == 0 ) { + my $s = $host_field->as_string('abc'); + if ($s) { + $sfd{d} = $s; + } + $index++; + } + if ( $host_field->indicator(1) && ( $host_field->indicator(1) eq '3' ) ) { + my $s = $host_field->as_string('abc'); + if ($s) { + $sfd{d} = $s; + } + last; } Theoretical objection only: If $s is empty in case1 or case2, you should probably not do index++ or last. So those should be moved actually into the inner if statement. But the host field would be invalid data surely. Passing QA nevertheless. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
