https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39657

Andrew Fuerste-Henry <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
            Summary|Optionally block API        |Block holds placed via the
                   |actions for expired patrons |API when patron would be
                   |                            |blocked from placing OPAC
                   |                            |hold

--- Comment #7 from Andrew Fuerste-Henry <[email protected]> ---
These patches pursue Katrin's option C, making the API behavior match what the
patron would be able to do via the OPAC.

Expanding this test plan a little for more detail:

To test:
1. Apply this patches
2. Run:
   $ ktd --shell
  k$ yarn api:bundle
  k$ koha-plack --restart kohadev
  k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
3. Test the endpoint with the various scenarios using your favourite
   REST tool (Postman!)

4. Have an expired patron; confirm BlockExpiredPatronOpacActions syspref set to
allow patrons to place hold via opac; confirm your patron can have holds placed
for them via API

5a. Set your expired patron's category to block holds for expired patrons;
confirm your patron cannot have a hold placed for them via the API

5b. Switch BlockExpiredPatronOpacActions syspref to block OPAC holds for all
expired patrons; switch your expired patron's category back to following the
syspref; confirm your patron still cannot have a hold placed for them via the
API


6. Have a patron flagged "Gone no address." Confirm they cannot have a hold
placed for them via the API
7. Repeat for a patron flagged "Lost card"
8. and a patron with debt greater than the maxoutstanding syspref
9. and a patron with a restriction
10. and a patron who already has as many holds as they're allowed by policy


11. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to