http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858
M. de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #37 from M. de Rooy <m.de.r...@rijksmuseum.nl> --- QA Comment: Good work! The first patch contains a lot of mixups with repeatable and mandatory flag for the MARC tags. (I see that you resolve them in the third patch.) The second patch contains a subfield 046 $3. It is not in the list of LOC. So I think that it should be removed until we are sure about it. The second (and third?) patch also has some problem with whitespace. I tried several things, but it keeps coming back in the lines around tag 082 - 086. Tag 260: You remove (IMPRINT), I think it should stay. See LOC. I checked all tags with LOC, but focused on mandatory/repeatable for the subfields. Rest looks good to me. Please make final corrections for: a) 046 $3 and 260 [You can probably amend Mason's patch, plz mention in commit] b) whitespace trouble Changing status to reflect need for minor adjustments. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/