https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40275

--- Comment #4 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
# Testing notes

All seems to work. I ran the following related tests successfuly:

```
prove -r t/db_dependent/SIP \
         t/db_dependent/Circ* \
         t/db_dependent/Auth*
```

# Caveats

As I understand it, `checkpw_internal()` should be adapted to use this as well.
But it implies a behavior change and I need more feedback in that.

The method seems to validate password for a patron found by `userid` and if
that validation fails, it tries with the `cardnumber`. I understand we don't
allow a cardnumber to match an existing userid, and the other way around. But I
want to hear from other devs about it. If that was the case, we could just use
`find_by_identifier()` and remove one of the blocks.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to