https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40292

--- Comment #19 from Victor Grousset/tuxayo <[email protected]> ---
This is what happens when hitting the bug. Apply the fix. And rerunning the
upgrade:

----------------------
== 1. run the old upgrade ==
Upgrade to 24.12.00.018  [19:43:50]: Bug 38663 - Add additional fields to
libraries
        Converting record_id from int(11) to VARCHAR(11)...

        ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an
error in your SQL syntax; check the manual that corresponds to your MariaDB
server version for the right syntax to use near 'COLUMN new_record_id TO
record_id' at line 1 at /kohadevbox/koha/C4/Installer.pm line 825
== 2. apply patches ==
== 3. retry to run the upgrade ==
kohadev-koha@kohadevbox:koha(testing-SO-QA)$ updatedatabase
Upgrade to 24.12.00.018  [19:45:11]: Bug 38663 - Add additional fields to
libraries
        No conversion needed for record_id column.
         ↑↑↑↑↑↑↑ that's where it leaves new_record_id
[....]
Upgrade to 24.12.00.045  [19:45:12]: Bug 38457 - Add additional fields to debit
types
        ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown
column 'record_id' in 'additional_field_values' at
/kohadevbox/koha/C4/Installer.pm line 825
----------------------


- the temporary new_record_id is still hanging around with the data: blocking,
fix should be obvious.
- it's type is VARCHAR(11) and the conversion to VARCHAR(80) has been skipped.
Non blocking and can end up staying like that. Causing a divergence with the
DBIC schema files. I don't know what that will mess up with.

Is there anything more to worry about? (and warranting more work, the above
isn't IMHO) Admins should hopefully have rollbacked the upgrade and restored a
backup instead of trying to guess what to fix. If they did anyway, then at
least above is a warning about one non obvious thing.
And they should look here for how to compare their database schema with
kohastructure.sql
https://gitlab.com/koha-community/koha-misc4dev/-/blob/e7657e08b73a0d7b5ef372c806ad14c32ceef667/run_tests.pl#L345

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to