https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947
--- Comment #84 from David Cook <[email protected]> --- (In reply to Jonathan Druart from comment #81) > Are you sure using Sort::Naturally is not enough? At least the tests pass. > If it's not enough please provide a test that makes this last patch fail. As per my above comment, we can't do an automated unit test within KTD currently that makes the last patch fail without interfering with the local KTD system. However, we can do a manual test. To test: 0. apt-get install libsort-naturally-perl 1. Perform all the test plans from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36947#c71 As expected, the "Use ncmp" patch fails the advanced test when the fi_FI locale is selected using FacetSortingLocale. The search results return the following which are incorrectly sorted for the Finnish language: aa author Aa author Åa author2 étienne Farley, David Humble, Jez Martin, Robert C. If you revert that patch (or checkout the one before it) and perform the test again, you get the correct result for the Finnish language: aa author Aa author étienne Farley, David Humble, Jez Martin, Robert C. Åa author2 -- Is that enough proof? I think you do raise a good point though about the unit tests. I hope that Tomas can give us a hand with getting out a new KTD that adds the fi_FI locale, so that we can do a unit test that proves this same thing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
