https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40224

--- Comment #4 from David Cook <[email protected]> ---
Comment on attachment 183443
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183443
Bug 40224: Replace use of location.href with POST logout form

Review of attachment 183443:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40224&attachment=183443)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
@@ +577,4 @@
>              // alert("checkout_confirm('" + patronid + "') called for 
> barcode '" + barcode + "'");
>              if (! barcode) { dofocus(); return false; }    // no barcode
>              if (barcode == "__KOHA_NEW_CIRC__") {   // magic barcode
> +                $("#logout_post_form").submit();

Let's avoid jQuery

@@ +651,4 @@
>                      confirmModal("", _("Would you like to print a 
> receipt?"), _("Print receipt and end session"), _("End session"), 
> function(result) {
>                          if ( result && (Date.now() - confirmStart) < [% 
> Koha.Preference('SelfCheckTimeout') | html %] ) {
>                              var win = 
> window.open("/cgi-bin/koha/sco/printslip.pl?print=qslip");
> +                            $("#logout_post_form").submit();

Let's avoid jQuery

@@ +655,2 @@
>                          } else {
> +                            $("#logout_post_form").submit();

Let's avoid jQuery

@@ +657,4 @@
>                          }
>                      })
>                  [% ELSE %]
> +                    $("#logout_post_form").submit();

Let's avoid jQuery

::: koha-tmpl/opac-tmpl/bootstrap/js/timeout.js
@@ +31,4 @@
>      _timer_increment() {
>          this.idle_time++;
>          if (this.idle_time >= this.idle_timeout) {
> +            $("#" + this.form_id).submit();

Let's try to avoid jQuery. This is trivial to do with regular Javascript.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to