https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40404
--- Comment #4 from Jonathan Druart <[email protected]> --- (In reply to Marcel de Rooy from comment #3) > This looks a bit weird and complex for what it should do. And it is/was > called test diag output. But it seems to do something else? Like checking > the former debug call? > > Please clarify what we want to achieve here and if this is the simplest way > to do it. The diag is not directly used, the different occurrences in the code can be found with `git grep '$logger->diag' t`. I don't really understand why we need it, but it seems useful in some context (re bug 38818). As I tried to explain in the commit message, we cannot use the regular warning_is from Test::Warn because diag will not write directly to STDERR. It's the only way I've found to remove the warning and be able to use NoWarnings in this test file. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
