https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|ASSIGNED |Failed QA --- Comment #28 from David Cook <[email protected]> --- A few obvious standout problems here: 1. Not sure what your 0005 file is there but it looks like it's not a patch 2. Database updates aren't done via updatedatabase.pl anymore. You'll want to read through https://wiki.koha-community.org/wiki/Database_updates 3. Commit author sometimes seems to be different to the person uploading. Also, sometimes commit author the default one from KTD. Would be good to fix/clarify these. 4. There are no commit messages and no test plan. Take a look at https://wiki.koha-community.org/wiki/Commit_messages 5. Looks like some patches would fail QA based on whitespace and formatting alone. Would be good for the author to use koha-testing-docker from development to avoid those kinds of errors Probably worth squashing a lot of these overall. I'm not sure about this design, but I haven't exhaustively reviewed the code. In any case, great to see some code trying to better organise the reports! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
