https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40405
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184129|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 184535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184535&action=edit Bug 40405: Set systempreferences.value to NOT NULL Some sysprefs have NULL as their default value, and systempreferences.value allows NULL values. However C4::Context->set_preference does not unset a syspref if "undef" is passed. Additionally some of the sysprefs that have NULL as default will generate warnings in the logs (and test suite output). opac/opac-suggestions.pl: for my $f ( split( /\s*\,\s*/, C4::Context->preference("OPACSuggestionUnwantedFields") ) ) { Here is the current list: +-------------------------------+-------+ | variable | value | +-------------------------------+-------+ | decreaseLoanHighHoldsDuration | NULL | | decreaseLoanHighHoldsValue | NULL | | ILLHiddenRequestStatuses | NULL | | ILLOpacbackends | NULL | | ILLSendStaffNotices | NULL | | ListOwnerDesignated | NULL | | MarcFieldDocURL | NULL | | MaxFine | NULL | | OPACSuggestionUnwantedFields | NULL | | ReportsExportLimit | NULL | | SerialsSearchResultsLimit | NULL | +-------------------------------+-------+ Test plan: Code review required here, please confirm the above and that the different occurrences do not use "undef" as a value. Note that some tests now do not longer generate warnings (eg. t/db_dependent/selenium/opac_ill_requests.t) Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
