https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412
Emily Lamancusa (emlam) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184021|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa (emlam) <[email protected]> --- Created attachment 184564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184564&action=edit Bug 38412: Display warning on biblio level When no item is available, with AllowHoldPolicyOverride, a triangle appears on each item to be forced, but if you choose “next item available” without having any item available, you won't see anything. Additionally, the top warning message about "No items are available" does not show when 'AllowHoldPolicyOverride' is set to allow and no items are available (e.g. withdrawn, lost, damanged, depending on settings) This patch corrects an error in request.pl where no incrementation of $num_override happens when an item is forced. This causes the warning triangle to appear on the 'Place hold' button on the bib level. The top warning message is restored as well. Finally, this patch changes the display of the fa-warning-triangle icon on the 'Place hold' buttons to increase contrast with the button color, making it easier to see and increasing accessibility. Test plan: 1) Set circulations rules for specific category and/or itemtype (for example 1 hold allowed for staff on books). Set AllowHoldPolicyOverride on "Allow". 2) Search for a book biblio with multiple items, and set each item to a non-circulating status (withdrawn, lost, etc.) 3) Place a hold for a staff category patron for this bib record. 4) Normally you will see triangles on each item on specific section but you can force it. When you just select the next item available none triangle and none alert showing. 5) Apply this patch and restart_all. 6) Refresh your browser page. 7) Normally now there is a triangle into 'Place hold' submit button and an alert message appears on the top of the page. The triangle is also more visible. 8) Test other hold limits, such as max holds per record, to ensure the appropriate top alert message appears and the triangle alert appears on the 'Place hold' button. Co-authored-by: Thibaud Guillot <[email protected]> Sponsored-by: BibLibre Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
