https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Pedro Amorim <[email protected]> --- Hey all, nice feature! From my testing everything appears to be working nicely, but I have some comments: A) Step 6: The 'Move selected (0)' button is not disabled. It's styled differently to the 'Cancel selected (0)' button. It still expands options when clicked even if no holds are selected. My suggestion would be to style it the same as 'Cancel selected (0)' and not expand options if no holds are selected. Ideally using the 'disabled' CSS class but may be out of scope (?). B) Step 13: If you enter a partial barcode like '76', 20 hits are returned (I believe only limited by the default paging of 20 from the REST API). I don't know if this needs addressing or not, but I wonder if an exact match for barcode here makes more sense. C) Step 15: Clicking 'Move all selected item level holds to this item' does enable the 'Move selected holds' button and the checkbox column under the 'Review holds to move' is ticked by default. If you untick the latter, and keep the top 'Move all...' checkbox ticked, then click 'Move selected holds', the page redirects as if something happened, but no holds were moved (because none were selected, in the modal). My suggestion would be to have this button disabled if no 'holds to move' are ticked. D) Step 17: After moving the hold(s), it's nice that a message is shown 'Moved from X to Y', but the URL becomes '/cgi-bin/koha/reserve/request.pl'. This causes clicks on any of the links on the left side menu to result on a 404 (or 500) errors. My suggestion would be to have this URL '/cgi-bin/koha/reserve/request.pl?biblionumber=X' with the original record's biblionumber (the 'moved from' record). E) Step 19: Moving record level holds, the modal says 'Enter the biblionumber of new hold target', but if you enter 'xyz' and then search, the error shown is 'No item found with barcode: xyz'. This error message should refer to the biblionumber e.g. 'Biblionumber 'xyz' not found.' I think these are all very minor, with the exception perhaps of D) that I'd consider a bit more of a blocker. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
