https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40529
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185141|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <[email protected]> --- Created attachment 185213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185213&action=edit Bug 40529: Add unit tests Test plan, k-t-d, patches applied: 1) Apply patches, enable DisplayAddHoldGroups system preference 2) Do a search for 'test': <staff_url>/cgi-bin/koha/catalogue/search.pl?q=test 3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button. 4) Enter the 'koha' user 5) Pick a pickup location for each of the holds and click 'Place holds'. 6) Visit the 'koha' patron: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7) Notice there are 3 holds all part of hold group '1' 8) Check-in one of the items in this hold group: 39999000005578. Confirm hold. 9) Repeat 6). Notice 'Continuous delivery' is now the hold group 'target'. 10) Place a new hold for one of the other 2 'non-target' holds for a different patron. Visit: <staff_url>/cgi-bin/koha/reserve/request.pl?biblionumber=29 11) Enter 'henry' on the patron input. Pick 'Henry Acevedo (23529000035676)'. Click 'Place hold'. Notice Henry's hold is priority 2. Let's check-in the item for this record: 39999000001310 12) Notice the eligible hold is Henry's, not the koha user's hold. This is because the hold that relates to koha's user is part of a hold group that already has a target so it was skipped. You may confirm the hold. 13) Now let's cancel 'target' hold, visit: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51 14) Click the 'Holds' tab and the red trash icon next to 'Continuous delivery'. Confirm cancellation. 15) Check the holds again, now there's only 2 holds in the existing group. 16) Let's repeat the exercise as before and place a hold for 'Henry' for 'Clean code', visit: <staff_url>/cgi-bin/koha/reserve/request.pl?biblionumber=114 17) Enter 'henry' and place a hold as before. 18) The 'Clean code' record now has 2 holds: first for 'koha' user and the second for 'Henry'. 19) Now check-in the item for that record. Notice it's the 'koha' user's hold that comes up. This is because it's first in priority and the hold is part of a hold group that does not yet have a target. Confirm hold. 20) Go back to 'Henry' and cancel his holds. Visit: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=19 21) Select 'both', click 'Cancel selected'. Confirm cancellation. 22) Visit 'holds to pull': <staff_url>/cgi-bin/koha/circ/pendingreserves.pl 23) Notice no holds show, even though 'koha' user has a hold that does not yet have an item assigned to it. This hold was skipped because it's part of a hold group that already has a target. To confirm this, disable DisplayAddHoldGroups and refresh 'Holds to pull'. Confirm it shows. 24) The same happens for the 'holds queue' i.e. 'non-target' holds are skipped. To test, with the sys pref still disabled, run the build_holds_queue.pl script: $ perl misc/cronjobs/holds/build_holds_queue.pl 25) Notice the 'non-target' hold shows, and that is expected if DisplayAddHoldGroups is disabled. Enable DisplayAddHoldGroups and repeat 24. Confirm the hold is gone. The behavior above works as described for holds that become 'In transit' or 'Waiting'. Run the updated test files: prove ./t/db_dependent/Koha/Hold.t prove ./t/db_dependent/Reserves/HoldGroup.t Relevant tests worth running to ensure no regressions are added to existing covered functionality: prove ./t/db_dependent/Circulation* prove ./t/db_dependent/Hold* prove ./t/db_dependent/Reserves* -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
