https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40636

            Bug ID: 40636
           Summary: C4::Reserves::CancelExpiredReserves behavior depends
                    on date it is run
 Change sponsored?: ---
           Product: Koha
           Version: Main
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

Looking at this method, I noticed (a few things, of which the more relevant is)
calculation depends on the date the method is called. For example:

If a hold expired on Monday but the script runs on Tuesday (which happens to be
a holiday), the hold that should have been canceled on Monday will be skipped
entirely, even though Monday wasn't a holiday.

The logic should be checking if the expiration date itself was a holiday, not
whether today is a holiday

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to