https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058

Emily Lamancusa (emlam) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |emily.lamancusa@montgomeryc
                   |                            |ountymd.gov
           Keywords|                            |additional_work_needed

--- Comment #11 from Emily Lamancusa (emlam) 
<[email protected]> ---
I'm afraid this has introduced a few new bugs - there are a few places in the
code where RevertWaitingStatus was being used to revert other found statuses,
which now throw an error 500:

- in request.tt, the "Revert waiting status" button's text changes to "Revert
transit status" if the hold is in-transit, but under the hood it's the same
code that calls revert_waiting either way

- when checking out an item with a found hold, if the user chooses to revert
the status of the hold and check out the item, revert_waiting gets called
regardless of which found status the item has

Any reason not to name the method revert_found and explicitly allow it to
revert any found status?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to