https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762
--- Comment #103 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 185827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185827&action=edit Bug 9762: (follow-up) Add integration tests and improve AddRenewal logging consistency This commit adds two key improvements to the Bug 9762 circulation override logging: 1. **Consistent JSON Logging**: Updated AddRenewal to always log in JSON format, matching AddIssue behavior. Previously AddRenewal only logged JSON when confirmations/forced were present, otherwise logged just the item number. 2. **Integration Tests**: Added comprehensive tests for both AddIssue and AddRenewal JSON logging functionality: - Test normal operations (empty confirmations/forced arrays) - Test override operations (populated confirmations/forced arrays) - Verify JSON structure and content accuracy The AddRenewal function now consistently logs: ```json { "issue": 123, "itemnumber": 456, "confirmations": [...], "forced": [...] } ``` This ensures uniform action log format across all circulation operations and provides better integration test coverage for the override logging functionality. Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
