https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40656
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185468|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 185860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185860&action=edit Bug 40656: Refactor bookings/list.tt to use better patterns and improve code organization This patch aims to improve bookings/list.tt: - Converting filter attributes to boolean data attributes (presence-based) - Creating a reusable table-filters.inc for filter controls - Moving inline styles to proper SCSS files for better caching and separation of concerns - Fixing a runtime error when cancelling bookings from the timeline - Improving JavaScript readability with helper functions - Addressing the QA complaints from Bug 36789: - Cleaning up the long lines for the button elements by moving them into template literals - Using the format method instead of direct interpolation - Using escape_str for all values received from the API. Test plan: 1. Apply the patch and compile css 2. Navigate to a biblio record with bookings (Catalog > Search > View record > Bookings) 3. Verify the filter buttons (Exclude expired/cancelled) appear correctly 4. Click each filter button and verify: - The button text toggles between "Include" and "Exclude" - The table updates to show/hide the appropriate bookings - The status column appears when any items are filtered 5. In the timeline view: - Verify cancelled bookings show with a strikethrough pattern - Try to cancel a booking by clicking the X on a timeline item - Confirm the cancel modal opens without JavaScript errors 6. Check that the table actions (Edit, Cancel) work correctly 7. Verify no inline styles remain in the page source 8. Confirm the filter styles are properly loaded from compiled CSS Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
