https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35761

Tomás Cohen Arazi (tcohen) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #56 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Hi, the DBIC schema seems to be manually tweaked (passiv vs. passive), probably
an unintended deletion. It prevents `updatedatabase` to run, but that's not a
problem because `dbic --force` fixes it and is not required to provide this
RM-generated files.

That said, I got a failure:

```
prove xt/api.t
```

which points to a problem with the response definition. It actually looks
weird:

```yaml
      "200":
        description: Results of FTP/SFTP server test
        schema:
          type: object
          items:
            $ref: "../swagger.yaml#/definitions/sftp_server"
```

which should probably be:

```yaml
      "200":
        description: Results of FTP/SFTP server test
        schema:
          $ref: "../swagger.yaml#/definitions/sftp_server"
```

but reading at the controller, it seems that the endpoint is not returning an
`sftp_server` object at all, but some connection test results in a JSON.

I suggest you add a spec for the response structure
(stfp_sever_test_results.yaml?) and follow the second example structure.

This is hiding something else I bet, as that response format would not validate
as an `sftp_server` object anyway and should be rejected by the OpenAPI plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to