https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #25 from Jonathan Druart <[email protected]> --- (In reply to Jonathan Druart from comment #23) > Those patches fix most of the issues. > > Remaining ones: > > not ok 455 - Koha/ExternalContent/OverDrive.pm has syntax warnings. > # Failed test 'Koha/ExternalContent/OverDrive.pm has syntax warnings.' > # at xt/pl_valid.t line 63. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 365. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 573. > # Possible precedence issue with control flow operator (die) at > /usr/share/perl5/WebService/ILS/OverDrive/Patron.pm line 643. 365 die ($data->{message} || $data->{errorCode})."\n"; 573 die ($data->{message} || $data->{errorCode})."\n"; 643 die ($data->{message} || $data->{errorCode})."\n"; This is weird, the code looks correct. I guess perl warns because it expects to see die and "or" instead of "||", but here it's not a die ... or! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
