https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40556

Lin Wei <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #184899|0                           |1
        is obsolete|                            |

--- Comment #2 from Lin Wei <[email protected]> ---
Created attachment 186174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186174&action=edit
Bug 40556 - Subfields names in control fields should not be displayed/editable

In cataloguing/addbiblio.pl, there is a conditionnal display of the subfield
name field.
However, it is depending on subfield_loo.fixedfield, which is never set up.
However, the field corresponding information is available in
innerloo.fixedfield.

<input type="text"
        title="[% subfield_loo.marc_lib | $raw %]"
        style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]"
        name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield |
html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html
%]"
        value="[% subfield_loo.subfield | html %]"
        size="1"

Moreover, following code does not make sense for control fields:

<span class="handle">&#xf58e;</span>

TEST PLAN:
1 - Edit any record. Note that you can grab subfields, note you can edit
  the 00 in the subfield input
2 - Apply patch
3 - On the same page, you should not be able to grab or edit subfield
  titles.

Signed-off-by: Ludovic julien <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to