http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499
--- Comment #13 from M. de Rooy <[email protected]> --- Although this patch is already pushed, I want to add some remarks: The code deletes the following lines: -for(my $i=0; $i<10;$i++){ - my $shelfnumber = $shelves[$i]->{number}; - if($shelfnumber<0) { - ok(1, 'Skip DelShelf for shelf -1'); - next; - } - my $status = DelShelf($shelfnumber); - ok(1 == $status, "deleted shelf $shelfnumber and its contents"); -} I do not agree with deleting those lines. Testing the DelShelf function should be done! Scrutiny :) I do agree with deleting this line: -DelBiblio($_) for @biblionumbers; I do not suggest to revert the patch however or send a followup. Why not? I am rebasing my patch on report 10441 that needs 9032 which is in Signed Off state. In this patch I will restore the DelShelf code. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
