https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40680
--- Comment #34 from Jonathan Druart <[email protected]> --- (In reply to David Cook from comment #32) > (In reply to Martin Renvoize (ashimema) from comment #31) > > Is this still in discussion.. what needs to happen next here? > > I think that's a question for Jonathan to answer. Not sure why he's moved it > to In Discussion. As discussed in the previous comments, we are waiting for Catalyst. We need hand on the module to provide a new version. (In reply to David Cook from comment #33) > The patches like "Fix TestBuilder" are fascinating. It looks like there are > a number of places where people have explicitly tried importing methods that > were never exported in the first place. Wild! Those imports have been auto-generated (Bug 17600: Standardize our EXPORT_OK). > Since there are so many patches on this one report, I suppose we'll need to > make a call of either trying to push them all ASAP or wait until after the > next release. > > Personally, I think it's risky making so many changes all at once, > especially when there are different types of changes made here. Some are > fixing BEGIN blocks in .pm modules while others are fixing that non-existent > import issue. They are not that big and an attentive code review can help to catch issues. They are all doing fixing import/export issues. IMO it makes sense to push them all at the same time. > But... regardless of how it's done I think we do need to push ahead. I don't > think we can afford to get stuck on this one. Hence the in discussion status, it's not ready. You can already review the existing patches, the remaining work is only about WebService::ILS::OverDrive. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
