http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565
--- Comment #16 from Kyle M Hall <[email protected]> --- (In reply to Liz Rea from comment #11) > I like this a lot. Like, a LOT. As in, I squeed when I was playing with it. > However, there is something really strange about the hover state of the > buttons - see http://img844.imageshack.us/img844/6169/iq7r.png > > That's Firefox 22 on Ubuntu Precise. It looks like the bootstrap css isn't playing well with Koha's css somewhere. I have it fixed in this new edition of the patch. > > Also, the unit test seems to fail: > > devlibrary-koha@wingardium-leviosa:/home/liz/koha-src/koha$ prove > t/db_dependent/PatronLists.t > t/db_dependent/PatronLists.t .. 1/9 DBIx::Class::Carp::__ANON__(): > "might_have/has_one" must not be on columns with is_nullable set to true > (Koha::Schema::Result::Borrower/cardnumber). This might indicate an > incorrect use of those relationship helpers instead of belongs_to. at > /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96 > t/db_dependent/PatronLists.t .. 5/9 > # Failed test 'AddPatronsToList works for cardnumbers' > # at t/db_dependent/PatronLists.t line 38. > # Looks like you failed 1 test of 9. > t/db_dependent/PatronLists.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/9 subtests > > Test Summary Report > ------------------- > t/db_dependent/PatronLists.t (Wstat: 256 Tests: 9 Failed: 1) > Failed test: 5 > Non-zero exit status: 1 > Files=1, Tests=9, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.70 cusr 0.04 > csys = 0.76 CPU) > Result: FAIL That's odd, I've run the test with multiple databases without an issue. Please try again with this followup patch. > Functional tests pass though... and I mean it when I say this is really > fantastic. People will throw confetti. Excellent! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
