https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37711

--- Comment #35 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
(In reply to David Cook from comment #22)
> > +                ALTER TABLE identity_provider_domains
> > +                    ADD COLUMN `auto_register_staff` tinyint(1) NOT NULL 
> > DEFAULT 0 COMMENT 'Allow user auto register (OPAC)'
> 
> The comment here should be:
> 'Allow user auto register (Staff interface)'

Fixed inline. Good catch!

> > +        <a class="btn btn-default" id="new_identity_provider_domain" 
> > href="/cgi-bin/koha/admin/identity_providers.pl?domain_ops=1&amp;identity_provider_id=[%-
> >  identity_provider_id | html -%]&amp;op=add_form"
> 
> I thought that we were using & instead of &amp; these days, but not really
> an issue...

The file is full of those. Maybe a separate bug to review how we build URLs
globally and add a check somewhere?

> - If you select "Auto register" "Yes" on
> http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form,
> and then you go to review the domain for that IdP, it'll say "Auto register
> (OPAC):" "Don't allow" and "Auto register (Staff)" "Don't allow".
> 
> - When viewing the "Identity provider domains for '<idp>'", there are 2
> tables. One appears to be the old table format which  has only 1 column
> "Auto register". This is the table that is populated. Beneath that table
> there is another one with the correct 2 "Auto register" columns, but no data
> is provided.

Bad rebase. Solved.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to