https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35590
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #25 from Julian Maurice <[email protected]> --- I think there are blocking issues with this patchset: - there is no 1:1 mapping between the languages in the dropdown list and the languages in PO files, meaning Koha has to search for corresponding PO files, can found multiple matching files, and uses only the first one. For instance, fr-FR-staff-prog.po will never be used because fr-CA-staff-prog.po comes first. - it assumes that there are translations for seasons in the PO files, but if this patch is accepted, having literal names for seasons in templates will become useless, and will eventually be removed, disappearing from PO files automatically. At the very least, seasons names in C4/Serials.pm should be wrapped inside N__() from Koha::I18N. This function is a no-op but it will ensure these strings will be added to PO files (in that case they will be added to the *-messages.po files, not *-staff-prog.po) and we can search for an exact match (and not the "%s$word%s" regex) - it duplicates some code from Koha::I18N, and in fact Koha::I18N can be used to replace a lot of code from this patch, under two conditions: - We need a 1:1 mapping between the language dropdown and PO files - Users will need to have installed (misc/translator/translate install) the languages to use them (because Koha::I18N needs the .mo files). Languages won't need to be enabled in the interface. With Koha::I18N it would look like this: Koha::I18N::set_language($locale); @seasons = (__('Summer'), __('Fall'), ...); Koha::I18N::reset_language(); set_language and reset_language needs to be implemented but basically they will only have to set $ENV{LANGUAGE} (No matter which of __ or N__ is used, it might be a good idea to use the 'p' variant to add some context, because words like "Win" can be ambiguous to translators) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
