https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40245

--- Comment #18 from CJ Lynce <[email protected]> ---
(In reply to Jonathan Druart from comment #16)
> 1. What does "showlegal" mean?
Show legal name (vs nickname or dead name), though in retrospect,
'showfirstname' would be more appropriate and match other language. 

> 2. [...]
Thanks for catching, I'll make that change (and remember for next time)

> 3. [...]
Good idea, and thanks for pointing out bug 40958. I'll adjust to incorporate
those changes.

> 4. Commit message states that it affects "search results and
> autosuggestions" but it's actually all patron searches (bug title should
> also be adjusted)

Thanks and good point, I will adjust. 

> 5.
> (In reply to Lucas Gass (lukeg) from comment #14)
> > Should we add a Cypress test?

I might need some help on this one, I've not written Cypress tests before. Is
there a past bug or two that has some good Koha-related examples to look at?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to