https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40141

--- Comment #9 from Jan Kissig <[email protected]> ---
(In reply to Paul Derscheid from comment #6)
> I have some things to note:
> 1. Maybe camel casing the functions would be more in line with the rest of
> the module.
> 2. I personally don't love the code duplication here but could maybe be
> consolidated in a follow up.
> 
> From a functionality standpoint this looks fine.

Thanks Paul, 
yeah I agree about that. I followed the kebab-case as the other functions were
already kebab-case in UsageStatisticsDataProvidersShow.vue

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to