https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40910
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from Marcel de Rooy <[email protected]> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #0) > Noticed in production, when `C4::SIP::ILS::Item->new` is passed an > `$item_id` that is not defined or empty -or barcodedecode makes it like > that- (e.g. faulty plugins) logs get flooded with DBIx::Class errors when it > should never reach the ORM with a query because there's nothing to search > for. You probably mean: DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/Koha/Objects.pm line 95 This only seems to occur when we look for undef. Not for empty string. Skipping a db search for undef or empty string is a good thing though. But do we really need 153 lines for that? t/db_dependent/SIP/Item.t | 153 ++++++++++++++++++++++++++++++++++++++ And if the argument is flooding the logs, we are still doing that here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
