https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866
--- Comment #17 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 187632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187632&action=edit Bug 40866: Implement Alternative pattern for holds override logging (Part 4) This patch implements proper override logging for holds following the Alternative implementation pattern used for checkouts and renewals. Instead of just removing the orphaned logging code from the original Bug 9762 implementation, this patch properly implements override logging by updating AddReserve to accept and log override information, similar to how AddIssue handles confirmations and forced overrides. Changes: C4/Reserves.pm: - Added JSON qw(to_json) import - Updated AddReserve to accept confirmations and forced parameters - Enhanced the existing logaction call to include override information in JSON format when overrides are present - Log format matches the Alternative implementation pattern: * hold ID * branchcode * biblionumber * itemnumber * confirmations array * forced array Koha/REST/V1/Holds.pm: - Added confirmations array building in the add() method - Pass 'HOLD_POLICY_OVERRIDE' confirmation when override_all is true - Pass confirmations parameter to AddReserve call reserve/request.pl: - Removed orphaned original implementation logging code - Removed unused variables and imports (message, @message, user, etc.) - Removed C4::Log import koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc: - Added 'HOLD_POLICY_OVERRIDE' case to translate_log_override block - Displays as "Hold policy override" in log viewer koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt: - Added JSON display handling for HOLDS module (similar to CIRCULATION) - Displays hold ID, biblionumber, and optional itemnumber with links - Shows forced and confirmation overrides using translate_log_override This ensures hold overrides are logged consistently with the Alternative implementation pattern, providing proper audit trails for policy overrides that are properly displayed in the log viewer. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
