https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30568
Brendan Lawlor <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Brendan Lawlor <[email protected]> --- As is this breaks links in the staff interface in the patron column of tables where patron-title.inc is included like the holds tab of a bib and the holds queue. It looks like it's caused by a recent change in bug 38714 and the rebase. Specifically starting at line 62: [%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] [%- IF link_to == 'circulation_reserves' -%] <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#reserves"> </a> [%- ELSIF link_to == 'circulation_recalls' -%] <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#recalls"> </a> [%- ELSIF link_to == 'members_pay' -%] <a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[%- patron.borrowernumber | uri -%]"> </a> [%- ELSE -%] <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[%- data.borrowernumber | uri -%]"> </a> [%- END -%] [%- END -%] These are rendered as empty links now. Prior to bug 38714 these anchor tags were left open and at then closed at the end of patron-title.inc lke this: [%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] </a> [%- END -%] I think it would be clearest now if that logic to wrap the display name in an anchor tag is brought inside [%- BLOCK display_patron_name -%] -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
