https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39871

Tomás Cohen Arazi (tcohen) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #15 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
I think the patches fix a real issue with the batchMod.pl tool and items. But I
also think the fix is hiding a bug in `Koha::Item->store()`, which should be
clearing those fields and isn't.

The issue is with this check:

```
            if (   exists $updated_columns{$field}
                && defined( $self->$field )
                && !$self->$field )
            {
                my $field_on = "${field}_on";
                $self->$field_on(undef);
            }
```

Which implies that setting one of the 'special' fields to `undef` will never
clear the corresponding `_on` field. It is important to fix this so other
people using the method can rely on it safely.

I will file a separate bug to talk about this.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to