https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40939

Brendan Lawlor <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187437|0                           |1
        is obsolete|                            |

--- Comment #3 from Brendan Lawlor <[email protected]> ---
Created attachment 187480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187480&action=edit
Bug 40939: Fix batch actions from report results

Batch patron operations are broken when using cardnumbers

From
  commit d659526b5ae3363de6dc7691a782a45aaf781a46
  Bug 38664: Tidy the whole codebase

-                                                [%- IF header_row.$place.cell
== batch_type || header_types.item(header_row.$place.cell) == batch_type %]
-[%# We must not add whitespace to the cardnumbers %][% cells.cell | html %]
+                                            [%- IF header_row.$place.cell ==
batch_type || header_types.item(header_row.$place.cell) == batch_type %]
+                                                [%# We must not add whitespace
to the cardnumbers %][% cells.cell | html %]

The auto tidy added the whitespaces back

This patch suggests to use TT to add the new lines.

+                                                [%- cells.cell | html -%][%
"\n" | $raw %][%# We want 1 item per line, without whitespace %]

Test plan:
- save and run "SELECT cardnumber FROM borrowers"
- use the Batch Operations button to send all visible cardnumbers to batch
patron modification
- see that all of your cardnumbers have been found

Signed-off-by: Brendan Lawlor <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to