https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40777
--- Comment #6 from Jonathan Druart <[email protected]> --- (In reply to Marcel de Rooy from comment #5) > From kohastructure > `homebranch` varchar(10) DEFAULT NULL COMMENT 'foreign key from the > branches table for the library that owns this item (MARC21 952$a)', > `holdingbranch` varchar(10) DEFAULT NULL COMMENT 'foreign key from the > branches table for the library that is currently in possession item (MARC21 > 952$b)', > > While both columns may still be NULL, we will have such issues. > What about NOT NULL to ensure integrity? > If we create an item somewhere or import it, we should probably know where > it belongs. Just suspecting that invalid branchcodes during import may be at > stake. > > And note that the REST API who is called to fetch the items, may need some > extra check while we dont address it in the table design? This is outside the scope. I have implemented the first test of misc/maintenance/search_for_data_inconsistencies.pl, but there are more: * incorrect item type (yes you could argue that a FK is missing as well for this one) * invalid marcxml * item fields in MARC * wrong authorised values * record without title The goal here is to offer the output of the script from the UI. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
