http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320
--- Comment #21 from Katrin Fischer <[email protected]> --- This looks nice and works well afaikt :) I am adding my passed QA to these patches, but we need a follow up: Please run the QA script and fix following problems and also the copyright statements Owen pointed out: FAIL C4/External/OverDrive.pm FAIL pod *** ERROR: =item without previous =over in file C4/External/OverDrive.pm FAIL koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt FAIL forbidden patterns forbidden pattern: tab char (line 143) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 34) forbidden pattern: tab char (line 148) Also I'd think it would be nice to have a non-Javascript fall back. For example you could prodie a simple search link in case Javascript is disabled in the browser. Please switch back to signed off when the follow up is ready and I will take a final look (or someone else who beats me to it :) ) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
