https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41034
Bug ID: 41034
Summary: Automaticitemreturn and transfer limits interaction is
very weird
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected], [email protected]
in C4/Circulation.pm around
2530 my $BranchTransferLimitsType =
C4::Context->preference("BranchTransferLimitsType") eq 'itemtype' ?
'effective_itemtype' : 'ccode';
2531 if (C4::Context->preference("AutomaticItemReturn" ) or
2532 (C4::Context->preference("UseBranchTransferLimits") and
2533 ! IsBranchTransferAllowed($branch, $returnbranch,
$item->$BranchTransferLimitsType )
2534 )) {
2535 my $transfer = ModItemTransfer($item->itemnumber, $branch,
$returnbranch, $transfer_trigger, { skip_record_index => 1 });
2536 $messages->{'TransferTo'} = $returnbranch;
2537 $messages->{'WasTransfered'} = $transfer->id;
2538 $messages->{'TransferTrigger'} = $transfer_trigger;
# In this case we create a transfer and prompt the librarian "Reason for
transfer:"
2539 } else {
2540 $messages->{'NeedsTransfer'} = $returnbranch;
2541 $messages->{'TransferTrigger'} = $transfer_trigger;
# In this case we ask the librarian whether they want to transfer or not
2542 }
These lines make no sense to me, in particular for following reasons:
- If there is AutomaticReturn, a transfer will be created without informing the
user, however it is forbidden
- If there is no AutomaticReturn, and branchtransfers is forbidden from target
branch to branch where we check-in (yes, in this direction), there will be a
transfer without asking to the user.
- Otherwise there is a confirmation box, even if it is a forbidden transfer,
and there is no mention that the transfer is forbidden.
If I understand well, there should be 3 cases.
1 - The transfer is not authorized, whatever the syspref AutomaticItemReturn,
we inform the librarian that this situation should not have happened and tell
to send the book to the proper library (should we there allow to create the
transfer by forcing restrictions ?).
2 - The transfer is authorized, and there is an automatic transfer -> fall back
in case 1
3 - The transfer is authorized, and there is no automatic transfer -> fall back
in case 2
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
