https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35700

--- Comment #9 from Lisette Scheer <[email protected]> ---
(In reply to Jonathan Druart from comment #8)
> I have some questions:
> 
> 1. 
> -  [ -date <YYYY-MM-DD> ]
> Why?

Accident, I had originally been adding an additional flag and accidentally
deleted this 

2. Also a hangover from my original overcomplication

I'm uploading a qa followup to fix these. 

> 3. Shouldn't we actually use Koha::Calendar::next_open_days here?

Instead of next if $calendar->is_holiday($date_to_run); or instead of something
else? 
addDays already uses next_open_days for calculating the date, we just need to
not run it on days there's a holiday to prevent duplicates.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to