https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41116

--- Comment #1 from Andrew Fuerste-Henry <[email protected]> ---
Created attachment 188517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188517&action=edit
Bug 41116: Standardize selectors in patron contact information in hold found
modals

This patch modifies both hold-found-modal and hold-found1. It adds a class to
the patron phone number. For patron email, it changes the existing id to a
class, expands the selector to include the bullet point in hold-found-modal,
and standardizes the name (changing from "#boreamil' to ".patronemail").

To test:
1 - have a patron with both a phone number and an email address
2 - create a hold for your patron
3 - check an item in to fill your hold, triggering the hold-found-modal
4 - inspect the patron contact info, confirm there is no class on the phone
number
5 - confirm there is an id on the patron email but it does not include the
bullet point and is inconsistent with the names of other classes in the modal
6 - click Confirm Hold
7 - check your item in again, triggering the hold-found1 modal
8 - confirm there is no class on the patron phone number
9 - confirm there is an id on the patron email with an inconsistent name
10 - revert the waiting status of your hold
11 - apply patch, restart_all
12 - check your item in again, triggering hold-found-modal
13 - confirm the patron phone now has a class, .patronphone
14 - confirm the patron email now has a class, .patronemail, that the class
includes the bullet point, and that the #boremail id has been removed
15 - click Confirm Hold
16 - check your item in again, triggering hold-found1 modal
17 - confirm the patron phone now has a class, .patronphone
18 - confirm the patron email now has a class, .patronemail, and that the
#boremail id has been removed

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to