https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37711
--- Comment #62 from David Cook <[email protected]> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #61) > (In reply to David Cook from comment #59) > > (In reply to David Cook from comment #58) > > > The only solution I can think of would be... > > > > Hmm maybe overly optimistic because I change that and it still fails with a > > 500 error. There's no stack trace so it's not clear where this code is being > > called. > > I submitted a patch that addresses the chicken-egg problem. Which you > identified correctly to be related to the Koha::Template::Plugin::AuthClient > class (instantiating the Koha::Identity::Providers). > > > This highlighted Koha was breaking badly if there was an error fetching the > IdPs. I decided it should just warn about the situation, and move forward so > wrapped it in a try/catch block. And added missing tests for the template > plugin while in the area. > > I set it back to SO so you can give it a last try for a final QA. > > Really glad you caught this. Thanks! Apologies for the delay in responding. Life's been a bit nuts. The additional patch looks good at a glance. I applied the patch and manually triggered the web installer and that worked well. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
