https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38050
--- Comment #50 from Jacob O'Mara <[email protected]> --- Thanks for the above! This latest patchset should address all of the above with one notable exception. All of the logic is now consistently uses the can_be_x checks and the sortfield logic is also integrated. My understanding of the allow_change_x columns was flawed as these seem to be for the add/removal of items from lists. Not typically lists themselves so those have been removed from this logic, list items endpoints will need to integrate with these though. The notable exception: There is no handling for if the virtualshelves pref is disabled, though this is currently consistent with other api’s. I couldn’t find any instances where we DO handle that. For instance the ERM api’s seem to all still work while it’s disabled and I couldn’t find any logic that should stop them from doing so. While I could technically add a syspref check at the top of all of the api methods, I think we would be better suited handling this at the router/swagger level. I can add a bug to that effect if you agree? Or, if I’m wrong, if you could point me at an example of endpoints that handle this, I would be happy to follow up. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
