https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #66 from David Cook <[email protected]> --- (In reply to Pedro Amorim from comment #61) > > (In reply to Jonathan Druart from comment #59) > > > 11. Missing changes in etc/koha-httpd.conf? > > > > I haven't checked all the places Jonathan mentioned but I have checked this > > one and in light of bug 41167, I'm marking this as Failed QA > > Thank you for bringing my attention to bug 41167, I was not aware of it. > However bug 41167 is not in main. I don't fully agree with FQA due to a bug > not yet in main, I think it opens a less then ideal precedent, though I > understand that it makes sense in this instance. Here is what I did: > 1) Fully rebased the branch on current main > 2) Made it depend on bug 41167 > 3) Added the patch: > https://github.com/openfifth/koha/commit/ > 57c5b64943ab72a744c2f9fcadf4c8b21e9d0b31 That's a good point. Initially I wasn't thinking of depending on bug 41167 but rather just adding the required 1 line to etc/koha-httpd.conf, but then that probably would've made for a merge conflict. Just bad timing, but thanks for taking care of it! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
