https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41097
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #4 from Marcel de Rooy <[email protected]> --- Looking at the code: This seems to be the only call: my ( $recordid_to_keep, @recordids_to_merge ) = _choose_records( $authority->authid, @recordids ); The POD says: returns first the record to merge to and list of records to merge from The sub makes no distinction between $authority->authid and @recordids. Note btw that @recordids is a BAD name; it contains MARC records ! sub _choose_records { my @recordids = @_; It returns candidate authids (picked from 001) but they are sorted. Why should the original first argument still be first? Shouldnt we add the first parameter (which is NOT a MARC record), not include that one while sorting and push it in front when returning values? This needs a bit more attention to clarify current obscureness while touching those lines here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
