http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643
Galen Charlton <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Galen Charlton <[email protected]> --- (In reply to Srdjan Jankovic from comment #2) > I propose something even better then - get rid of prepare() all together. > For example: > > * GetClassSources(): > return $dbh->selectall_hashref("SELECT...", undef, 'cn_source'); > > * AddClassSource() > return $dbh->do("INSERT...", undef, @params) > > etc. How often are those used to get advantage of prepare_cached()? > Good databases (tm) cache queries anyway, however not sure that MySQL does. Getting rid of $sth->finish() and replacing prepare_cached() with prepare() suffices as a minimal change, but doesn't preclude going further and using selectall_hashref. As far as the current patch is concerned, I do think it would be useful to at least get rid of prepare_cached(). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
